Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated to 2023-08-01-preview swagger changes . perimeter access rule… #7738

Merged

Conversation

bhupeshbhatt1985
Copy link
Contributor

@bhupeshbhatt1985 bhupeshbhatt1985 commented Jun 24, 2024

Description:
Added support for service tag based perimeter access rule.
Swagger updated to 2023-08-01-preview swagger changes . a


This checklist is used to make sure that common guidelines for a pull request are followed.
aaz PR: Azure/aaz#507

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Jun 24, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️nsp
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd network perimeter profile access-rule create cmd network perimeter profile access-rule create added parameter service_tags
⚠️ 1006 - ParaAdd network perimeter profile access-rule update cmd network perimeter profile access-rule update added parameter service_tags

Copy link

Hi @bhupeshbhatt1985,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 24, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Jun 24, 2024

For more info about extension versioning, please refer to Extension version schema

src/nsp/HISTORY.rst Outdated Show resolved Hide resolved
@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jun 26, 2024
@AllyW
Copy link
Member

AllyW commented Jun 26, 2024

⚠️ Release Suggestions

Module: nsp

  • ⚠️ Please update VERSION to be 1.0.0b1 in src/nsp/setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

@bhupeshbhatt1985 please refer to this link for correcting module version update, thanks

@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jun 26, 2024
@bhupeshbhatt1985
Copy link
Contributor Author

⚠️ Release Suggestions

Module: nsp

  • ⚠️ Please update VERSION to be 1.0.0b1 in src/nsp/setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

@bhupeshbhatt1985 please refer to this link for correcting module version update, thanks

@AllyW updated to [1.0.0b1] as per suggestion and understanding from the document. Bot has removed the block tag after that but ci failing . please review and suggest if this is correct or not.

@kairu-ms
Copy link
Contributor

kairu-ms commented Jul 1, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kairu-ms kairu-ms merged commit f4a98e7 into Azure:main Jul 1, 2024
18 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Jul 1, 2024

[Release] Update index.json for extension [ nsp ] : https://dev.azure.com/azclitools/release/_build/results?buildId=168780&view=results

@bhupeshbhatt1985
Copy link
Contributor Author

@kairu-ms Please don't release it. I need to make a fix.

@bhupeshbhatt1985
Copy link
Contributor Author

@kairu-ms I raised another PR , fixing the issue. #7769 .

liorstauber pushed a commit to liorstauber/azure-cli-extensions that referenced this pull request Jul 14, 2024
Azure#7738)

* updated to 2023-08-01-preview swagger changes . perimeter access rule changes for servicetag based rule.

* removed the updated commands for perimeter and profile and updated history

* removed NSP based rule example

* fixed message

* fixed servicetag example

* update test recordings

* update api version

* fixed failing tests

* added tests for service tag

* updated version , 0.4.0 from 0.3.0 as new apiversion added

* isExperimental to isPreview

* updated release version

* updated version to 1.0.0b1

* text formatting in hostory file

---------

Co-authored-by: Bhupesh Bhatt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants